Re: [Further-devel] Plugins: xmms/launcher

From: Chris Ball (chris@cpan.org)
Date: Fri May 25 2001 - 18:13:47 PDT


On Fri, May 25, 2001 at 06:06:20PM -0700, Evan Martin wrote:
> On Sat, May 26, 2001 at 01:30:20AM +0100, Chris Ball wrote:
> > - evas_move(evas, edate, dpy_width - text_width - 5, clock_height);
> > + evas_move(evas, edate, dpy_width - text_width - 5, clock_height + 10);
>
> Ideally, this'll all be covered by the configuration system, eventually.

Yep. It's not too easy to have /any/ idea of where to put things when
you don't know the fonts/sizes being used by other plugins; hopefully
the config system will let us have access to things like that. Somehow.
Hrm. :)

> > + while (fscanf(fp, "%s %s", exec, icon) != EOF) {
> > + printf("exec: %s\t icon: %s\n", exec, icon);
> > + add_icon(exec, icon, x, y);
> > + x += 50;
> > + }
>
> Hm... I don't think this will work. Each fscanf overwrites the buffer,
> and you're passing the address of the buffer to each icon.

It does work, but.. yes. Woops. :o)

> Also, how will this handle command lines with spaces?

Hrm. Will they be part of the second %s? I'm pretty sure it's working.
Please do tidy, though. :)

> This looks good, though some sort of progress bar might be more
> appropriate.
> Maybe I'll play with some of the gradient functions...

*stares at the screen and drools*

> And this can be simplified a bit, but I'll commit something like it.
> Thanks for this bit-- I've been wishing I had something like this. :)

It's all Ed's - I don't have my mouse wheel working in X at the moment.
*ponders going to play with XF86Conf*

> Does this work? Or is the additional code in each of the buttons
> necessary?

I'll leave it to Ed to talk about. I'm sure it's there in response to a
problem he encountered with capturing the clicks. Ed?

> Thanks for the patch!

No probs. (I think more of that patch is Ed's code rather than mine, btw)
Thanks for further. I could definitely get used to this whole open source
thing, y'know.. ;)

-- 
Chris Ball.
chris@cpan.org || http://printf.net/
"You said Java, that's as bad as "Belgium". --trj"

_______________________________________________ Further-devel mailing list Further-devel@lists.sourceforge.net http://lists.sourceforge.net/lists/listinfo/further-devel



This archive was generated by hypermail 2.1.2 : Sun Nov 11 2001 - 14:16:15 PST