Re: [Further-devel] x2 plugin

From: Chris Ball (chris@cpan.org)
Date: Wed Nov 07 2001 - 11:06:09 PST


On Tue, Nov 06, 2001 at 01:26:03PM -0800, Evan Martin wrote:
> New XMMS plugin, with a different idea: minimal use of screen space.
> Inspired by the Windows XP media player (do the XP login icons remind
> anyone else of further?).

Haven't used XP. I like the x2 layout a lot, though.

> The x and y parameters don't matter yet.

x does now[1]. :-) I'd imagine you want a top or bottom boolean for y,
though, rather than co-ords, given that the sliding would be broken if it
wasn't on a screen edge. Up to you, of course.

Thanks,

~C.

[1]: I'm not sure why you didn't do this to begin with. Feel free to
ignore the diff if there was a reason against allowing an x co-ord..

--- further/plugins/x2/xmms.c Tue Nov 6 21:16:07 2001
+++ furthercur/plugins/x2/xmms.c Wed Nov 7 20:06:24 2001
@@ -34,8 +34,10 @@
         double bx,by;
         int wheelx;
         int i;
-
- bx = dpy_width - CONTROLSWIDTH;
+
+ /* Grab x from the conf system, take it into account. */
+ x = plugin->x;
+ bx = dpy_width - CONTROLSWIDTH - x;
         by = y + text_height + 2;
 
         wheelx = bx < x ? bx : x;

-- 
Chris Ball.
chris@cpan.org || http://printf.net/
"Of course hair is fish. How else do you explain Japanese people and cats?"

_______________________________________________ Further-devel mailing list Further-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/further-devel



This archive was generated by hypermail 2.1.2 : Sun Nov 11 2001 - 14:16:15 PST