On Sun, Jun 17, 2001 at 10:41:48AM -0700, Evan Martin wrote:
> My comments/changes: (Things I didn't change are marked as such.)
> - I'm not sure how valuable two digits of precision are... or even one,
> for that matter, but one is what top uses. (No change.)
Yeah, I think you're right... the number of decimal places could be set
as a #define
> - I switched the further event model back to not using glib, so I made
> some minor changes there.
Okay, I really should grab the latest CVS - not having my linux box on
the internet is very annoying
> - I added a copyright at the top, attributing it to you. Yay for
> distributed copyright! Further will never be sold!
> - I'm not sure that opening the stats file once per second is really
> efficient... I don't know how much of a load it puts on the system.
> Maybe open the file when the plugin loads? (No change.)
Yeah, it probably would be better to only open it once though... its
just I was hoping to have all the load reading stuff in one function for
portability - so it can just be replaced by one for an alternative
> - How can we make this not break on non-Linux platforms? Is there some
> sort of #define we can use? (No change.)
I've found some code for BSD and Solaris. I've got a FreeBSD box that'll
try it on next week - the Makefile is probably going to have to be the
place where the correct code is used though
> - I really need to make the configuration language... so far, I've
> managed to avoid using any color other than fullwhite, because that
> color can work against a variety of backgrounds... (No change.)
Have you got any ideas for this yet? If there's anything I can do (and I
know Chris is the same) then let us know
"Do you know, I think it is? I really think it might just be a crazy little thing called sarcasm seeping in at the edges of my manner of speech!"
This archive was generated by hypermail 2.1.2 : Sun Nov 11 2001 - 14:16:15 PST